-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SAME7/V7/S7 SDK support #171
base: master
Are you sure you want to change the base?
Conversation
# SEPARATE MODULES | ||
set(module_list "") | ||
set(module_list_supported "") | ||
set_module_support(module_list module_list_supported ${MCU_NAME} "hal_ll_layer") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add all other missing modules such as CAN
. They are defined in a separate cmake file anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added CAN, DMA and RTC.
static const hal_ll_adc_pin_map_t _adc_map[] = | ||
{ | ||
#ifdef ADC0_PD30_CH0 | ||
{PD30, HAL_LL_ADC0_BASE_ADDR, hal_ll_adc_module_num(ADC_MODULE_0), HAL_LL_ADC_CHANNEL_0}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change all occurrences of Pxy to GPIO_Pxy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed all occurrences in all pin_map header files.
**/ | ||
typedef struct hal_ll_gpio_interrupt_register_handle | ||
{ | ||
uint32_t enable; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use hal_ll_base_addr_t
typedef instead of uint32_t
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For all implementations including the AI-generated ones we use uint32_t for gpio headers. I can make an exception for this file, but I think we can follow the original approach.
/*!< @brief UART hw specific module values */ | ||
typedef struct | ||
{ | ||
uint16_t pin_tx; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check file for appropriate use of hal_ll_base_addr_t
and hal_ll_pin_name_t
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed it for all source files where needed.
targets/arm/mikroe/sam/src/uart/implementations/implementation_1/hal_ll_uart.c
Outdated
Show resolved
Hide resolved
targets/arm/mikroe/sam/src/uart/implementations/implementation_1/hal_ll_uart.c
Show resolved
Hide resolved
targets/arm/mikroe/sam/src/uart/implementations/implementation_1/hal_ll_uart.c
Show resolved
Hide resolved
targets/arm/mikroe/sam/src/uart/implementations/implementation_1/hal_ll_uart.c
Show resolved
Hide resolved
Co-authored-by: Strahinja Jacimovic <strahinja.jacimovic@mikroe.com>
Co-authored-by: Strahinja Jacimovic <strahinja.jacimovic@mikroe.com>
…_1/hal_ll_uart.c Co-authored-by: Strahinja Jacimovic <strahinja.jacimovic@mikroe.com>
Co-authored-by: Strahinja Jacimovic <strahinja.jacimovic@mikroe.com>
Co-authored-by: Strahinja Jacimovic <strahinja.jacimovic@mikroe.com>
…_1/hal_ll_uart.c Co-authored-by: Strahinja Jacimovic <strahinja.jacimovic@mikroe.com>
…_1/hal_ll_uart.c Co-authored-by: Strahinja Jacimovic <strahinja.jacimovic@mikroe.com>
…_1/hal_ll_uart.c Co-authored-by: Strahinja Jacimovic <strahinja.jacimovic@mikroe.com>
Co-authored-by: Strahinja Jacimovic <strahinja.jacimovic@mikroe.com>
Co-authored-by: Strahinja Jacimovic <strahinja.jacimovic@mikroe.com>
Co-authored-by: Strahinja Jacimovic <strahinja.jacimovic@mikroe.com>
Co-authored-by: Strahinja Jacimovic <strahinja.jacimovic@mikroe.com>
…1/hal_ll_adc.c Co-authored-by: Strahinja Jacimovic <strahinja.jacimovic@mikroe.com>
…1/hal_ll_adc.c Co-authored-by: Strahinja Jacimovic <strahinja.jacimovic@mikroe.com>
…1/hal_ll_i2c_master.c Co-authored-by: Strahinja Jacimovic <strahinja.jacimovic@mikroe.com>
…tation_1/hal_ll_spi_master.c Co-authored-by: Strahinja Jacimovic <strahinja.jacimovic@mikroe.com>
Added support for SAM MCUs.
This PR is connected to this core PR due to necessity of floating point enabling.
ATSAM SDK testing status can be found here