Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display control type filter as dropdown #2801

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

missionfloyd
Copy link
Contributor

The control types are starting to take up a lot of space.
Untitled

This adds an option to put them in a dropdown instead.
image

@huchenlei
Copy link
Collaborator

See reason why it is not a dropdown: #1422 (comment)

@missionfloyd
Copy link
Contributor Author

That's why I made it optional.

Copy link
Collaborator

@huchenlei huchenlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huchenlei
Copy link
Collaborator

Do note that some JS hacks will be broken if you change it to dropdown:

this.controlTypeRadios = tab.querySelectorAll('.controlnet_control_type_filter_group input[type="radio"]');

@missionfloyd missionfloyd marked this pull request as draft April 24, 2024 04:24
@missionfloyd missionfloyd marked this pull request as ready for review April 24, 2024 05:17
@huchenlei huchenlei merged commit 281c715 into Mikubill:main Apr 24, 2024
2 checks passed
@missionfloyd missionfloyd deleted the control-type-dropdown branch April 25, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants