Skip to content

Commit

Permalink
Make modlauncher a compile only dependency as it is optional at runtime.
Browse files Browse the repository at this point in the history
  • Loading branch information
LexManos committed Mar 18, 2024
1 parent dc0fbc7 commit 9ce967e
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
7 changes: 4 additions & 3 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,9 @@ repositories {
dependencies {
api(libs.typetools)
implementation(libs.log4j.api)
implementation(libs.modlauncher)
implementation(libs.securemodules)
implementation(libs.bundles.asm)
compileOnly(libs.modlauncher)
compileOnly(libs.securemodules)
compileOnly(libs.nulls)
}

Expand Down Expand Up @@ -96,7 +97,7 @@ allprojects {
'Oracle': (16..21),
'SAP': (16..20)
]

// Tests are expensive to run all variants, so only run if asked to
if (!project.hasProperty('bulk_tests'))
ext.VALID_VMS = ['Adoptium': [17]]//, 18, 19, 20, 21] ]
Expand Down
2 changes: 1 addition & 1 deletion eventbus-test/src/test/java/module-info.java
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

// Custom events we're testing
requires static net.minecraftforge.eventbus.testjars;
requires net.minecraftforge.unsafe;
requires net.minecraftforge.unsafe;

provides cpw.mods.modlauncher.api.ITransformationService with
net.minecraftforge.eventbus.test.MockTransformerService;
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/module-info.java
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*/
open module net.minecraftforge.eventbus {
uses net.minecraftforge.eventbus.IEventBusEngine;
requires cpw.mods.modlauncher;
requires static cpw.mods.modlauncher;

requires org.objectweb.asm;
requires org.objectweb.asm.tree;
Expand Down

0 comments on commit 9ce967e

Please sign in to comment.