Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #246, #213
Replaces #224
Proposed Changes
This PR introduces a CRI logging driver as an alternative solution to #213. This driver outputs docker logs in CRI formats. Docker has dual logging capability that will take care of also outputting the logs in JSON format.
The driver creates a CRI logger to output CRI formatted logs to the location specified by kubelet. This logger will exist within
cri-dockerd
. i.e.cri-dockerd
will handle it's current GRPC messages as well as the logger messages fromdockerd
The driver will need to be installed with
cri-dockerd
and specified incri-dockerd
's code when it creates a container along with the kube file location. The kube file location is passed to the driver to eliminated the need to create a kube client within the driver when it already exists incri-dockerd
.Changes Still Needed
cri-dockerd
The driver will now run as a part of
cri-dockerd
. My thoughts are to havecri-dockerd
telldockerd
it is installedusing something like https://docs.docker.com/engine/api/v1.43/#tag/Plugin/operation/PluginPull.
cri-dockerd
to specify the driver and kube path when creating a container