S3 triggers apply incorrectly with multiple stages using the same bucket

[arcadecoffee]

Context

If multiple stages use the same S3 bucket and events but with different prefixes, deployments, undeployments, schedules apply the S3 bucket events incorrectly.

Expected Behavior

Each stage should be capable of deploying it's own triggers and underlying only its own triggers.

Actual Behavior

The first deployment works correctly but subsequent deployments do not add the events for those stages. Undeployment of any stage deletes all events if the missing events have been added manually.

Possible Fix

During deployment or undeployment, bucket notification configurations in place as identified by trigger id should be compared to desired state (current state plus or minus event in question) and resulting configuration applied to the bucket.

Steps to Reproduce

Using zappa_settings.json below:

1. zappa deploy dev
2. Note trigger on lambda and event on S3 bucket
3. zappa deploy stage
4. Note the lack of the trigger on lambda and event on S3 bucket

Your Environment

zappa_settings.json:

{
  "dev": {
    "app_function": "example.app",
    "aws_region": "us-east-1",
    "profile_name": "default",
    "project_name": "zappa-example",
    "runtime": "python3.7",
    "s3_bucket": "zappa-123456",
    "events": [
      {
        "function": "example.dev_app",
        "event_source": {
          "arn": "arn:aws:s3:::bucketname1234",
          "key_filters": [
            {
              "type": "prefix",
              "value": "dev"
            }
          ],
          "events": [
            "s3:ObjectCreated:*"
          ]
        }
      }
    ]
  },
  "stage": {
    "app_function": "example.app",
    "aws_region": "us-east-1",
    "profile_name": "default",
    "project_name": "zappa-example",
    "runtime": "python3.7",
    "s3_bucket": "zappa-123456",
    "events": [
      {
        "function": "example.stage_app",
        "event_source": {
          "arn": "arn:aws:s3:::bucketname1234",
          "key_filters": [
            {
              "type": "prefix",
              "value": "stage"
            }
          ],
          "events": [
            "s3:ObjectCreated:*"
          ]
        }
      }
    ]
  },
  "prod": {
    "app_function": "example.app",
    "aws_region": "us-east-1",
    "profile_name": "default",
    "project_name": "zappa-example",
    "runtime": "python3.7",
    "s3_bucket": "zappa-123456",
    "events": [
      {
        "function": "example.app",
        "event_source": {
          "arn": "arn:aws:s3:::bucketname1234",
          "key_filters": [
            {
              "type": "prefix",
              "value": "prod"
            }
          ],
          "events": [
            "s3:ObjectCreated:*"
          ]
        }
      }
    ]
  }
}

[arcadecoffee]

This is fixed here : #2126

[eversdyk]

Reviewed fix #2126 which prevents unintended/accidental deletion of S3 event triggers