Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make S3 triggers apply correctly with multiple stages using the same bucket #2125

Closed
wants to merge 27 commits into from

Conversation

arcadecoffee
Copy link

@arcadecoffee arcadecoffee commented Jun 23, 2020

Description

The S3EventSource handler from Kappa has been re-implemented to allow more precise addition and removal of S3 bucket event triggers allowing Zappa to work when multiple stages, app_functions, or even whole projects to apply and manage their own triggers on S3 buckets.

GitHub Issues

S3 triggers apply incorrectly with multiple stages using the same bucket #2111

@coveralls
Copy link

coveralls commented Jun 23, 2020

Coverage Status

Coverage increased (+0.1%) to 73.113% when pulling cda35d7 on SpareFoot:fix-s3-events into 93804a1 on Miserlou:master.

@arcadecoffee arcadecoffee marked this pull request as ready for review June 23, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants