Docker enhancements #2440
Closed
Docker enhancements #2440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added docker-compose_swarm.yml for deployment in docker swarm mode on single node. Fixed postgres volume mount in docker-compose.yml
ajinabraham
reviewed
Nov 6, 2024
ajinabraham
reviewed
Nov 6, 2024
| - POSTGRES_HOST=postgres | ||
| - POSTGRES_PORT=5432 | ||
| - MOBSF_API_KEY_FILE=/run/secrets/mobsf_api_key | ||
| image: ${MOBSF_IMAGE:-opensecurity/mobile-security-framework-mobsf:v4.0.7} |
There was a problem hiding this comment.
can this be pointing to latest?
There was a problem hiding this comment.
I thought that it's better to refer to specific version in specific release. In this way it should be more consistent. Also it's similar to postgres(I've left corresponding comments below)
There was a problem hiding this comment.
We prefer to use the latest image for all examples. It makes sense for posrgres, but for mobsf image, please tag the latest.
ajinabraham
reviewed
Nov 6, 2024
|
Changes merged in #2445 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the Pull Request
Checklist for PR
tox -e lint,testStaticAnalyzer/tests.py)Additional Comments (if any)