UT for EnqueueCommandBuffer #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shajder
requested changes
Oct 17, 2023
| @@ -3604,6 +3606,54 @@ void testCommandBufferInfoKHRCommandQueues(void) | |||
| TEST_ASSERT_EQUAL_PTR(make_command_queue(2), command_queues[2]()); | |||
| #endif | |||
| } | |||
|
|
|||
| static cl_int clEnqueueCommandBufferKHR_testEnqueueCommandBuffer( | |||
| cl_uint num_queues, | |||
There was a problem hiding this comment.
We could verify num_queues at least once
| { | ||
| #if defined(cl_khr_command_buffer) | ||
| std::vector<cl::CommandQueue> command_queues; | ||
| command_queues.emplace_back(commandQueuePool[0]()); |
There was a problem hiding this comment.
Let's increase number of queues for second call with commandQueuePool[1], thanks
shajder
requested changes
Oct 17, 2023
Comment on lines
+3650
to
+3651
| ret = notValidCommandBuffer.enqueueCommandBuffer(command_queues, nullptr, nullptr); | ||
| TEST_ASSERT_EQUAL(ret, CL_INVALID_COMMAND_BUFFER_KHR); |
There was a problem hiding this comment.
At least in one case we could deliver wait list. Then it should be tested in clEnqueueCommandBufferKHR_testEnqueueCommandBuffer like this:
TEST_ASSERT_EQUAL(1, num_events_in_wait_list);
TEST_ASSERT_EQUAL_PTR(make_event(1), event_wait_list[0]);
TEST_ASSERT_EQUAL(0, num_calls);
if (event != nullptr)
{
*event = make_event(2);
}
There was a problem hiding this comment.
@shajder Corrections added for all comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UT for EnqueueCommandBuffer