Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UT for commandNDRangeKernel #22

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

UT for commandNDRangeKernel #22

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5254980
UT commandNDRangeKernel
kamil-goras-mobica Oct 12, 2023
d01722b
Added real data for kernel, ranges, sync_point check
kamil-goras-mobica Oct 16, 2023
ffb7ea8
minor fix
shajder Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions tests/test_openclhpp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3631,11 +3631,20 @@ static cl_int clCommandNDRangeKernelKHR_testCommandNDRangeKernel(cl_command_buff

TEST_ASSERT_NOT_NULL(sync_point);
TEST_ASSERT_EQUAL_PTR(nullptr, mutable_handle);

TEST_ASSERT_EQUAL_PTR(kernelPool[0](), kernel);
TEST_ASSERT_EQUAL(2, global_work_offset[0]);
TEST_ASSERT_EQUAL(5, global_work_size[0]);

switch (cmock_to_return)
{
case 0:
{
TEST_ASSERT_EQUAL_PTR(nullptr, command_queue);
if (sync_point != nullptr)
{
*sync_point = 15;
}
return CL_SUCCESS;
}
case 1:
Expand All @@ -3652,8 +3661,8 @@ void testCommandNDRangeKernel(void)
#if defined(cl_khr_command_buffer)
cl::vector<cl_ndrange_kernel_command_properties_khr> properties{ 0,1,2 };
cl::Kernel kernel;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preference to remove unused variable

cl::NDRange offset;
cl::NDRange global;
cl::NDRange offset{ 2 };
cl::NDRange global{ 5 };
cl::NDRange local = cl::NullRange;
std::vector<cl_sync_point_khr> sync_points_vec{ 3,2,1 };
cl_sync_point_khr sync_point{ 2 };
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least one call could verify returned sync_point

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shajder added correction

Expand All @@ -3663,7 +3672,7 @@ void testCommandNDRangeKernel(void)
clCommandNDRangeKernelKHR_StubWithCallback(clCommandNDRangeKernelKHR_testCommandNDRangeKernel);
cl_int ret = commandBufferKhrPool[0].commandNDRangeKernel(
properties,
kernel,
kernelPool[0],
offset,
global,
local,
Expand All @@ -3672,10 +3681,11 @@ void testCommandNDRangeKernel(void)
mutable_handle,
command_queue);
TEST_ASSERT_EQUAL(ret, CL_SUCCESS);
TEST_ASSERT_EQUAL(15, sync_point);

ret = commandBufferKhrPool[0].commandNDRangeKernel(
properties,
kernel,
kernelPool[0],
offset,
global,
local,
Expand Down