Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UT for compile #6

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

UT for compile #6

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3461e8d
UT for compile
piotr-wozniak-mobica Aug 7, 2023
125e52b
Added some corrections
kamil-goras-mobica Oct 19, 2023
0a2d7e3
Merge branch 'main' into ut_compile
kamil-goras-mobica Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 57 additions & 0 deletions tests/test_openclhpp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4571,6 +4571,63 @@ void testgetObjectInfo() {
TEST_ASSERT_EQUAL(type, CL_GL_OBJECT_BUFFER);
TEST_ASSERT_EQUAL(bufobj, 0);
}

#if CL_HPP_TARGET_OPENCL_VERSION >= 120
static cl_int clGetProgramInfo_testcompile(cl_program program,
cl_program_build_info param_name,
size_t param_value_size,
void *param_value,
size_t *param_value_size_ret,
int /*num_calls*/) {
TEST_ASSERT_EQUAL_PTR(make_program(0), program);
TEST_ASSERT_EQUAL_HEX(CL_PROGRAM_DEVICES, param_name);
TEST_ASSERT(param_value == nullptr ||
param_value_size >= sizeof(cl_context));
if (param_value_size_ret != nullptr)
*param_value_size_ret = sizeof(cl_context);
if (param_value != nullptr)
*static_cast<cl_context *>(param_value) = make_context(0);
return CL_SUCCESS;
}

static cl_int clCompileProgram_testcompile(
cl_program program, cl_uint num_devices, const cl_device_id *device_list,
const char *options, cl_uint num_input_headers,
const cl_program *input_headers, const char **header_include_names,
cmock_cl_func_ptr6 pfn_notify, void *user_data, int num_calls) {
TEST_ASSERT_EQUAL_PTR(program, make_program(0));
TEST_ASSERT_EQUAL(num_devices, 0);
TEST_ASSERT_EQUAL_PTR(device_list, nullptr);
TEST_ASSERT_EQUAL_PTR(options, nullptr);
TEST_ASSERT_EQUAL(num_input_headers, 0);
TEST_ASSERT_EQUAL_PTR(input_headers, nullptr);
TEST_ASSERT_EQUAL_PTR(header_include_names, nullptr);
TEST_ASSERT_EQUAL(pfn_notify, 0);
TEST_ASSERT_EQUAL_PTR(user_data, nullptr);
TEST_ASSERT_EQUAL(num_calls, 0);
return CL_COMPILE_PROGRAM_FAILURE;
}

void testcompile() {
const char *options = nullptr;
void(CL_CALLBACK * notifyFptr)(cl_program, void *) = nullptr;
void *data = (void *)nullptr;
cl_int ret = 0;

clGetProgramInfo_StubWithCallback(clGetProgramInfo_testcompile);
clGetDeviceInfo_StubWithCallback(clGetDeviceInfo_platform);
clGetPlatformInfo_StubWithCallback(clGetPlatformInfo_version_1_1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is minor but can we put below two calls next to each other separated to other _StubWithCallbacks calls :

    clGetDeviceInfo_StubWithCallback(clGetDeviceInfo_platform);
    clGetPlatformInfo_StubWithCallback(clGetPlatformInfo_version_1_1);

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shajder Added corrections, please take a look

clGetProgramBuildInfo_StubWithCallback(clGetProgramBuildInfo_testGetBuildInfo);

clCompileProgram_StubWithCallback(clCompileProgram_testcompile);

ret = programPool[0].compile(options, notifyFptr, data);
TEST_ASSERT_EQUAL(ret, CL_COMPILE_PROGRAM_FAILURE);
}
#else
void testcompile() {}
#endif // CL_HPP_TARGET_OPENCL_VERSION >= 120

#if CL_HPP_TARGET_OPENCL_VERSION >= 210
static cl_int clGetHostTimer_testgetHostTimer(cl_device_id device,
cl_ulong *host_timestamp,
Expand Down