Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gbfs validator script fix #188

Merged
merged 4 commits into from
Jun 5, 2024
Merged

gbfs validator script fix #188

merged 4 commits into from
Jun 5, 2024

Conversation

Alessandro100
Copy link
Contributor

There was an issue when installing the npm package npm i gbfs-validator --save after the submodule addition. I discovered from the package.json postinstall script will trigger when users install the package using npm i gbfs-validator --save. This caused an error where it would try to update the submodules when trying to download the package.

Solution
The prepare lifecycle script will trigger a submodule update on a local npm install but NOT when a user downloads the package npm i gbfs-validator --save. It will also trigger just before npm publish. This is the functionality we wanted from the beginning

Note: I deployed version 1.0.11 locally to make sure this fix works, and it does!

@Alessandro100 Alessandro100 self-assigned this Jun 5, 2024
Copy link

netlify bot commented Jun 5, 2024

Deploy Preview for gbfs-validator ready!

Name Link
🔨 Latest commit e1ffa15
🔍 Latest deploy log https://app.netlify.com/sites/gbfs-validator/deploys/666068897874fc0008178ae5
😎 Deploy Preview https://deploy-preview-188--gbfs-validator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Alessandro100 Alessandro100 merged commit cef2f44 into master Jun 5, 2024
7 checks passed
@Alessandro100 Alessandro100 deleted the fix/validator-script-fix branch June 5, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants