Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix traditional chinese translation #54

Closed
wants to merge 1 commit into from
Closed

fix traditional chinese translation #54

wants to merge 1 commit into from

Conversation

jameslinjl
Copy link

I was taking a look at the gtfs.org website translations, and noticed that the traditional Chinese translation was actually using simplified characters in a large portion of the translation.

@jameslinjl
Copy link
Author

Hi @isabelle-dr @fredericsimard ! I'm interested in helping out with some GTFS related development and documentation. Let me know if there's a process that I should follow to get 👀 on any changes I'm hoping to contribute :)

@emmambd
Copy link
Contributor

emmambd commented Nov 23, 2022

@jameslinjl As discussed during our call, thank you so much for taking the time to work on this contribution! We're going to talk to Simpleen, the DeepL automated translation service we use, to see if we can resolve this issue with the traditional Chinese at the source before accepting manual translation contribution. I will likely share with you the "fixed" version when we resolve this so we can get your thoughts on the quality of the new and improved translation.

@jameslinjl jameslinjl closed this by deleting the head repository Dec 21, 2022
@emmambd emmambd reopened this Feb 28, 2023
@emmambd
Copy link
Contributor

emmambd commented Feb 28, 2023

Hi @jameslinjl! I'm going to reopen this PR and merge these changes after doing a big audit of our translations — we've decided to accept manual translations and commit to making sure we're only re-translating them when the original paragraph(s) change. We want to use these great contributions! Thanks again for doing this.

@emmambd
Copy link
Contributor

emmambd commented Mar 13, 2023

Hi @jameslinjl! Working on getting these changes merged — could you make your repo public so we can see the conflicts? Then we can see how complex they are and decide how to fix them.

@jameslinjl
Copy link
Author

@emmambd could you give it a try now?

@jameslinjl
Copy link
Author

I had deleted the previous fork, so possible that i need to create a new PR based on the fork i just created

@emmambd
Copy link
Contributor

emmambd commented Jun 1, 2023

Closing in favor of #144 - sorry for the wait @jameslinjl! Thanks for making the repo public - I was able to update the PR.

@emmambd emmambd closed this Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants