fix: UI OpenApi generator fails to create a proper Feed's discriminator #555
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes: #560
The TS types are included as part of the repository. We are using the generate:api-types library to generate the types. Until now, it was at the developers' discretion to run the generator. A breaking change was introduced in a previous PR, and it was not until last week we realized that the TS types were broken when trying to generate the new version. The breaking changes were necessary because the Python fastApi generator, used on the server side, doesn't fully support the
anyOf
oroneOf
OpenApi feature.Changes:
allOf
by a schema component containing all properties from BasicFeed, GtfsFeed and GtfsRTFeed.discriminator
to the BasicFeed to support TS code generation.Testing tips:
Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.sh
to make sure you didn't break anything