Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add created_at timestamp to feed response #558

Merged
merged 3 commits into from
Jul 15, 2024
Merged

feat: add created_at timestamp to feed response #558

merged 3 commits into from
Jul 15, 2024

Conversation

cka-y
Copy link
Contributor

@cka-y cka-y commented Jul 11, 2024

Summary:

Closes #533 by adding the created_at field to the responses of the basic feed, GTFS feed, and GTFS-RT feed.

Expected behavior:

The created_at field should appear in the API responses for the basic feed, GTFS feed, and GTFS-RT feed. The field should contain a timestamp indicating when the feed was created.

Example response:

{
    "id": "mdb-195",
    "data_type": "gtfs",
    "status": "active",
    "created_at": "2024-07-11T15:24:16.631817Z",
   // other existing fields
}

Testing tips:

  • Run the API locally to ensure the changes are correctly integrated.
  • Verify that the created_at field is present in the responses for the basic feed, GTFS feed, and GTFS-RT feed.
  • Check that the created_at field contains a valid timestamp reflecting the creation time of the feed.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@cka-y
Copy link
Contributor Author

cka-y commented Jul 11, 2024

After this pull request is merged and the database changes are deployed to PROD, we need to ensure to run the following script to update the created_at dates in the database:
created_at_update.sql.zip

@cka-y cka-y merged commit da93909 into main Jul 15, 2024
2 checks passed
@cka-y cka-y deleted the feat/533 branch July 15, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add created_at timestamp to feed response
2 participants