Refactored 1.21 networking #29
Conversation
| private NetworkingUtil() { | ||
| } | ||
|
|
||
| public static boolean cantEditGlowcase(ServerPlayerEntity player, BlockPos pos, GlowcaseBlock glowcase) { |
There was a problem hiding this comment.
I know Intellij disagrees with me here, but I think it's more readable to have it be "canEditGlowcase" (even if that means it's always inverted)
| this.url = tag.getString("url"); | ||
| } | ||
|
|
||
| public EditHyperlinkBlock createPacketData() { |
There was a problem hiding this comment.
I might rename this to "createEditPacket" since I think that's more descriptive. But that'd be in a separate codestyle pass, nothing that would block this pr
There was a problem hiding this comment.
I guess this would apply for all the other BEs with packets too, then?
I wonder if something like an interface or abstract super class would be good to enforce / abstract this whole structure a bit better.
There was a problem hiding this comment.
Also, I think I will move from short to byte for the enum packet codec entries too.
If there is ever going to be an enum with more entries than the byte size, there is something definitely wrong with the enum, and it should probably refactored to be something like a list or map...
There was a problem hiding this comment.
my suggestion on this - EditPacket<T extends BlockEntity> extends CustomPayload
contains
void send()- defaulted c2s send.void receive(context)- abstract for packets to implementEditPacket create(T blockEntity)- construct packet from blockentity.
Anything that's not public from the BE that needs to be, just make it public.
…enum packed codec size from short to byte
# Conflicts: # src/main/java/dev/hephaestus/glowcase/block/entity/HyperlinkBlockEntity.java # src/main/java/dev/hephaestus/glowcase/block/entity/ItemDisplayBlockEntity.java # src/main/java/dev/hephaestus/glowcase/block/entity/TextBlockEntity.java # src/main/java/dev/hephaestus/glowcase/client/gui/screen/ingame/HyperlinkBlockEditScreen.java # src/main/java/dev/hephaestus/glowcase/client/gui/screen/ingame/ItemDisplayBlockEditScreen.java # src/main/java/dev/hephaestus/glowcase/client/gui/screen/ingame/TextBlockEditScreen.java # src/main/java/dev/hephaestus/glowcase/networking/GlowcaseClientNetworking.java # src/main/java/dev/hephaestus/glowcase/networking/GlowcaseCommonNetworking.java
src/main/java/dev/hephaestus/glowcase/networking/packet/EditItemDisplayBlockSettings.java
Show resolved
Hide resolved
src/main/java/dev/hephaestus/glowcase/networking/packet/EditItemDisplayBlockSettings.java
Show resolved
Hide resolved
| this.url = tag.getString("url"); | ||
| } | ||
|
|
||
| public EditHyperlinkBlock createPacketData() { |
There was a problem hiding this comment.
my suggestion on this - EditPacket<T extends BlockEntity> extends CustomPayload
contains
void send()- defaulted c2s send.void receive(context)- abstract for packets to implementEditPacket create(T blockEntity)- construct packet from blockentity.
Anything that's not public from the BE that needs to be, just make it public.
Notes
this.blockEntitiy.createPacketData().send();so block entities create the data for their packets. You can also just create a new instance of the packet manually if needed thoPACKET_CODECfor enums uses short values now instead of int values since the amount of enum entries will never reach an integer size (even byte might be enough for most enums?)ServerPlayConnectionEvents.INITevent and registered global receivers now