Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the outline block #50

Merged
merged 9 commits into from
Nov 15, 2024
Merged

Added the outline block #50

merged 9 commits into from
Nov 15, 2024

Conversation

Chailotl
Copy link

@Chailotl Chailotl commented Oct 4, 2024

No description provided.

sisby-folk
sisby-folk approved these changes Oct 6, 2024
View reviewed changes
Copy link

@sisby-folk sisby-folk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! diff needs a little clean, and could you swap to the new item texture?

src/main/java/dev/hephaestus/glowcase/Glowcase.java Outdated Show resolved Hide resolved
@Chailotl
Copy link
Author

Alright, I've made the changes you requested, and included the item display block texture update as well, this should be ready to merge

sisby-folk
sisby-folk approved these changes Nov 15, 2024
View reviewed changes
Copy link

@sisby-folk sisby-folk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this a lotl

@sisby-folk sisby-folk merged commit 10a19bb into ModFest:1.21 Nov 15, 2024
1 check passed
@Chailotl Chailotl deleted the wireframe-block branch November 16, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sisby-folk sisby-folk sisby-folk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Chailotl @sisby-folk