Added crawlStrict setting for finer detection in JS & CSS Files
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… crawnling JS & CSS files. JS tests are only detected when a property of the Modernizr object. CSS/SASS/LESS tests are only detected when they are a class scoped to the HTML element
|
Hi @madlandproject sorry for not looking at PRs sooner :-( Are you still interested in pushing this PR? If so, could you rebase it against the latest master and make sure that the test-files are not included (those are noise). Maybe adding a new test for this feature would be nice though ;-) |
|
Would fix #26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in the updated README.md, This option makes crawling more precise ad avoids false positives if you are strict in the use of the Modernizr object in JS and HTML element scope in CSS.