Replace node-zopfli with imagemin-zopfli #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@patrickkettner I am still trying to get the page running on my local environment. The download page is still giving me trouble regarding the _.map function (see #72) Any ideas or is it working on your machine? |
|
it is working on mine, I haven't had time to dig into why it would be failing otherplaces :( |
|
weird... what is your config (os, node, npm)? |
|
windows 10, node 10, whatever latest npm is today |
|
here its a mac os with node 10.4.1, npm 6.10, bower 1.8.4, doing a fresh install with cleaned caches, running |
|
Opened a new issue for that in #128 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node-zopfli is not building right now and seems to be not maintained anymore. so lets use the working imagemin solution for zopfli.