Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(topic): Detect illegal config change and force recreate. #135

Conversation

rojopolis
Copy link

Since I'm not aware of any other illegal config transitions I decided to just special case delete -> compact.

Addresses #134

@Mongey
Copy link
Owner

Mongey commented Jun 26, 2020

@rojopolis am I right in saying that this is only illegal on confluent-cloud, and, for non-ccloud brokers, it's ok to go from delete -> compact ? if that's the case, in order to support this, we should add a flag to the provider, to have users indicate that this behaviour is desired.

@rojopolis
Copy link
Author

@rojopolis am I right in saying that this is only illegal on confluent-cloud, and, for non-ccloud brokers, it's ok to go from delete -> compact ? if that's the case, in order to support this, we should add a flag to the provider, to have users indicate that this behaviour is desired.

Unfortunately, I don't know :(

If so, a dry-run may be a better approach since it would leave it up to the server to decide whether a requested change requires a re-create.

I can see if I can implement that... I'm not sure I have the required Kafka knowledge.

@rojopolis
Copy link
Author

Superseded by #136

@rojopolis rojopolis closed this Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants