Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature add test ids #190

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

kmagnusj
Copy link

I'm using the TapRating component in a work project and want to do testing for the component with Jest. I've added a testID input and default value, as well as some testIDs for parts of the component.

Pretty simple PR, but let me know if there are any guidelines I should have followed or any name changes you would like to be made.

Cheers!

Copy link
Owner

@Monte9 Monte9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Suggested a few changes before we can merge this!

src/TapRating.tsx Outdated Show resolved Hide resolved
src/TapRating.tsx Outdated Show resolved Hide resolved
src/TapRating.tsx Outdated Show resolved Hide resolved
@kmagnusj
Copy link
Author

@Monte9 Hey man, sorry for the late notice. I made the changes as per your request, now I just need you to resolve the conflict. It seems like a small one for the props of the TapRating component. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants