Add printing of which package failed to clean in aur cache #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good change but I'm not a fan of the nesting here and change of a for loop to a for_each. The compiler warning about unused values is a sign it's probably not the ideal way to write this. I think the way to do this is just .with_context() the original error returned by |
|
@Morganamilo how about now? This is what it looks like |
Morganamilo
reviewed
Nov 28, 2023
| let file_name = file.file_name(); | ||
| tr!( | ||
| "could not parse .SRCINFO for '{}'", | ||
| file_name.to_string_lossy() |
There was a problem hiding this comment.
use .display() here instead. Otherwise all good.
There was a problem hiding this comment.
Actually this is the filename and not a Path so nevermind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently installed a package from the AUR that
srcinfo.rsfailed to parse the.SRCINFOof. As a result, when I attempted to clean the caches (withparu -Sc), I get an error message of the parse failure, but there is no indication of which package the error originated from. This PR adds that information to the output.Before
After