Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unknown change events #162

Merged
merged 5 commits into from
May 8, 2024
Merged

Fix unknown change events #162

merged 5 commits into from
May 8, 2024

Conversation

Morphclue
Copy link
Owner

Context

Last time I moved some dates, I've noticed that they don't get updated anymore into an unknown state.
According to the usage of the $unset doc from MongoDB they use { $unset: { quantity: "", instock: "" } } with an empty string. Even if the specific declaration of the value is not necessary, I have used it as a guide.

Furthermore I've noticed that event inside the filter was of type string. Therefore a correct comparison wasn't possible.

@Morphclue Morphclue added bug Something isn't working backend This issue focuses on the backend labels May 5, 2024
@Morphclue Morphclue requested a review from Clashsoft May 5, 2024 10:33
apps/backend/src/poll/poll/poll.service.ts Outdated Show resolved Hide resolved
apps/backend/src/poll/poll/poll.service.ts Outdated Show resolved Hide resolved
@Morphclue Morphclue requested a review from Clashsoft May 7, 2024 17:44
@Clashsoft Clashsoft merged commit 22f1632 into master May 8, 2024
4 checks passed
@Clashsoft Clashsoft deleted the fix/move-events-unknown branch May 8, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend This issue focuses on the backend bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants