Darkmode using Bootstrap 5.3 #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clashsoft
added
enhancement
# Conflicts: # pnpm-lock.yaml
Clashsoft
force-pushed
the
feat/darkmode
branch
from
aa8c725
to
25b6f33
Compare
Morphclue
approved these changes
Feb 11, 2024
Open
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a darkmode using Bootstrap 5.3 and some overrides for contrast. Ngbx is used for the syncing and saving themes.
Right now there are still some issues, especially with the calendar views.
Screenshots
Problems
Selection colors don't look too good:
The calendar is completely white:
The autofill calendar selection is slightly miscolored:
The token text is black:
As shown in the poll presets and the settings dialog, the primary/secondary colors are way too dark.