-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup does not use cached download of sscache #107
Comments
Oh, you are right. Would you like to give it a fix? |
I'd like, but am unable. Best I could do is drop the note of what I noticed. |
i10416
added a commit
to i10416/sccache-action
that referenced
this issue
Jun 18, 2024
As mentioned in Mozilla-Actions#107, `setup` function didn't use `find` function even though it uses `cacheDir` to store downloaded files, which leads to redundant download. It is not significant on GitHub-hosted runners because `cacheDir` stores files in local file system, which is ephemeral. However, it wastes time on self-hosted runners. This commit adds a step to search local file system cache for sccache as well as splitting download procedure to a dedicated function.
sylvestre
pushed a commit
to i10416/sccache-action
that referenced
this issue
Jun 18, 2024
As mentioned in Mozilla-Actions#107, `setup` function didn't use `find` function even though it uses `cacheDir` to store downloaded files, which leads to redundant download. It is not significant on GitHub-hosted runners because `cacheDir` stores files in local file system, which is ephemeral. However, it wastes time on self-hosted runners. This commit adds a step to search local file system cache for sccache as well as splitting download procedure to a dedicated function.
sylvestre
pushed a commit
to i10416/sccache-action
that referenced
this issue
Jul 18, 2024
As mentioned in Mozilla-Actions#107, `setup` function didn't use `find` function even though it uses `cacheDir` to store downloaded files, which leads to redundant download. It is not significant on GitHub-hosted runners because `cacheDir` stores files in local file system, which is ephemeral. However, it wastes time on self-hosted runners. This commit adds a step to search local file system cache for sccache as well as splitting download procedure to a dedicated function.
sylvestre
pushed a commit
to i10416/sccache-action
that referenced
this issue
Jul 18, 2024
As mentioned in Mozilla-Actions#107, `setup` function didn't use `find` function even though it uses `cacheDir` to store downloaded files, which leads to redundant download. It is not significant on GitHub-hosted runners because `cacheDir` stores files in local file system, which is ephemeral. However, it wastes time on self-hosted runners. This commit adds a step to search local file system cache for sccache as well as splitting download procedure to a dedicated function.
sylvestre
pushed a commit
that referenced
this issue
Jul 18, 2024
* fix: avoid downloading package when local cache exists As mentioned in #107, `setup` function didn't use `find` function even though it uses `cacheDir` to store downloaded files, which leads to redundant download. It is not significant on GitHub-hosted runners because `cacheDir` stores files in local file system, which is ephemeral. However, it wastes time on self-hosted runners. This commit adds a step to search local file system cache for sccache as well as splitting download procedure to a dedicated function. * fix: explicit comparison for boolean-like value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It seems the action calls
cacheDir
to save a downloaded and extracted sscache, but it does not usefind
to see if it is already in the cache and calls directlydownloadTool
to download it again.The text was updated successfully, but these errors were encountered: