fix: avoid downloading package when local cache exists #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i10416
commented
Jun 18, 2024
| // Search local file system cache for sccache. | ||
| // This is useful when actions run on a self-hosted runner. | ||
| let sccacheHome = find('sccache', version); | ||
| if (sccacheHome === '') { |
There was a problem hiding this comment.
It seems find returns empty string when a tool is not found.
sylvestre
force-pushed
the
fix/add-local-cache-search-before-download
branch
from
bbaa6a8
to
de2ec3d
Compare
sylvestre
force-pushed
the
fix/add-local-cache-search-before-download
branch
from
de2ec3d
to
5201bf8
Compare
As mentioned in Mozilla-Actions#107, `setup` function didn't use `find` function even though it uses `cacheDir` to store downloaded files, which leads to redundant download. It is not significant on GitHub-hosted runners because `cacheDir` stores files in local file system, which is ephemeral. However, it wastes time on self-hosted runners. This commit adds a step to search local file system cache for sccache as well as splitting download procedure to a dedicated function.
sylvestre
force-pushed
the
fix/add-local-cache-search-before-download
branch
from
5201bf8
to
8dbd02f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in
#107,
setupfunction didn't usefindfunction even though it usescacheDirto store downloaded files, which leads to redundant download.It is not significant on GitHub-hosted runners because
cacheDirstores files in local file system, which is ephemeral. However, it wastes time on self-hosted runners.This commit adds a step to search local file system cache for sccache as well as splitting download procedure to a dedicated function.