Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid downloading package when local cache exists #123

Merged
merged 2 commits into from
Jul 18, 2024
Merged

fix: avoid downloading package when local cache exists #123

merged 2 commits into from
Jul 18, 2024

Commits on Jul 18, 2024

  1. fix: avoid downloading package when local cache exists 

    As mentioned in
Mozilla-Actions#107,
`setup` function didn't use `find` function even though it uses
`cacheDir` to store downloaded files, which leads to redundant download.

It is not significant on GitHub-hosted runners because
`cacheDir` stores files in local file system, which is ephemeral.
However, it wastes time on self-hosted runners.

This commit adds a step to search local file system cache for sccache as
well as splitting download procedure to a dedicated function.
    @i10416 @sylvestre
    i10416 authored and sylvestre committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    cf6047a View commit details
    Browse the repository at this point in the history

  2. fix: explicit comparison for boolean-like value

    @i10416 @sylvestre
    i10416 authored and sylvestre committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    8dbd02f View commit details
    Browse the repository at this point in the history