Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve MultiMessageSender #76

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Improve MultiMessageSender #76

merged 2 commits into from
Sep 22, 2023

Conversation

Dominator008
Copy link
Collaborator

  • Require the caller to specify fees to each adapter. Removing on-chain fee estimation which may not work with some adapters.
  • Maintain a senderAdapters array sorted in ascending order by address.

@Dominator008
Improve MultiMessageSender
c37a573 
- Require the caller to specify fees to each adapter. Removing on-chain
  fee estimation which may not work with some adapters.
- Maintain a senderAdapters array sorted in ascending order by address.
ermyas
ermyas reviewed Sep 19, 2023
View reviewed changes
src/MultiMessageSender.sol Outdated Show resolved Hide resolved
src/MultiMessageSender.sol Outdated Show resolved Hide resolved
src/MultiMessageSender.sol Outdated Show resolved Hide resolved
src/libraries/Error.sol Outdated Show resolved Hide resolved
@ermyas ermyas merged commit 12f460e into main Sep 22, 2023
3 checks passed
@ermyas ermyas mentioned this pull request Sep 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ermyas ermyas ermyas approved these changes

@sujithsomraaj sujithsomraaj Awaiting requested review from sujithsomraaj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dominator008 @ermyas