feat: revert if all message bridges fail #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ermyas
reviewed
Oct 4, 2023
ermyas
reviewed
Oct 6, 2023
ermyas
reviewed
Oct 6, 2023
src/libraries/Error.sol
Outdated
| @@ -102,6 +102,9 @@ library Error { | |||
| /// @dev is thrown if contract call is invalid (for axelar) | |||
| error NOT_APPROVED_BY_GATEWAY(); | |||
|
|
|||
| /// @dev is thrown if all message bridges fail | |||
There was a problem hiding this comment.
Suggested change
| /// @dev is thrown if all message bridges fail | |
| /// @dev is thrown if a message could not be sent through a sufficient number of bridges |
ermyas
reviewed
Oct 7, 2023
src/MultiBridgeMessageSender.sol
Outdated
| uint256 _nativeValue, | ||
| uint256 _expiration, | ||
| address _refundAddress, | ||
| uint256[] calldata _fees, | ||
| address[] calldata _excludedAdapters | ||
| uint256[] memory _fees, |
There was a problem hiding this comment.
Suggested change
| uint256[] memory _fees, | |
| uint256[] calldata _fees, |
ermyas
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #95