PLGCSCS-138: Fix the options within the select field for Ideal issuer…

…s (#48)
MultiSafepay · Dec 22, 2022 · 6e3a233 · 6e3a233
1 parent fc38080
commit 6e3a233
Show file tree

Hide file tree

Showing 3 changed files with 40 additions and 37 deletions.
diff --git a/src/app/lib/other/smarty/plugins/block.msp_issuers.php b/src/app/lib/other/smarty/plugins/block.msp_issuers.php
@@ -32,8 +32,6 @@ function smarty_block_msp_issuers($params, $content, &$smarty, &$repeat)
 
     require_once (DIR_ROOT . '/app/payments/MultiSafepay.combined.php');
 
-
-
     if ($processor_data['processor_params']['mode'] == 'T') {
         $test = true;
     } else {
@@ -48,23 +46,25 @@ function smarty_block_msp_issuers($params, $content, &$smarty, &$repeat)
 
     $iDealIssuers = $msp->getIdealIssuers();
 
+    $idealselect = '<div class="litecheckout__field cm-field-container litecheckout__field--small litecheckout__field--state">';
+    $idealselect .= '<select name="payment_info[issuer]" class="issuerselect litecheckout__input litecheckout__input--selectable litecheckout__input--selectable--select" id="issuerselect">';
 
-    $idealselect = '<select name="payment_info[issuer]" class="issuerselect" id="issuerselect"><option value="">Kies uw bank</option>';
+    if (!empty($iDealIssuers['issuers']['issuer'])) {
+        $idealselect .= '<option value="">Kies uw bank</option>';
 
-    if ($processor_data['processor_params']['mode'] == 'T') {
-        foreach ($iDealIssuers['issuers'] as $issuer) {
-            $idealselect .= '<option value="' . $issuer['code']['VALUE'] . '">' . $issuer['description']['VALUE'] . '</option>';
-        }
-    } else {
         foreach ($iDealIssuers['issuers']['issuer'] as $issuer) {
-            $idealselect .= '<option value="' . $issuer['code']['VALUE'] . '">' . $issuer['description']['VALUE'] . '</option>';
+            if (!empty($issuer['code']['VALUE']) && !empty($issuer['description']['VALUE'])) {
+                $idealselect .= '<option value="' . $issuer['code']['VALUE'] . '">' . $issuer['description']['VALUE'] . '</option>';
+            }
         }
     }
-    $idealselect .= '</select>';
-
-
+    else {
+        // There are no banks available
+        $idealselect .= '<option value="">Er zijn geen banken beschikbaar</option>';
+    }
+    $idealselect .= '</select></div>';
 
     return $idealselect;
 }
 
-?>
+?>
diff --git a/src/app/lib/other/templater/plugins/block.msp_issuers.php b/src/app/lib/other/templater/plugins/block.msp_issuers.php
@@ -46,23 +46,25 @@ function smarty_block_msp_issuers($params, $content, &$smarty, &$repeat)
 
     $iDealIssuers = $msp->getIdealIssuers();
 
+    $idealselect = '<div class="litecheckout__field cm-field-container litecheckout__field--small litecheckout__field--state">';
+    $idealselect .= '<select name="payment_info[issuer]" class="issuerselect litecheckout__input litecheckout__input--selectable litecheckout__input--selectable--select" id="issuerselect">';
 
-    $idealselect = '<select name="payment_info[issuer]" class="issuerselect" id="issuerselect"><option value="">Kies uw bank</option>';
+    if (!empty($iDealIssuers['issuers']['issuer'])) {
+        $idealselect .= '<option value="">Kies uw bank</option>';
 
-    if ($processor_data['processor_params']['mode'] == 'T') {
-        foreach ($iDealIssuers['issuers'] as $issuer) {
-            $idealselect .= '<option value="' . $issuer['code']['VALUE'] . '">' . $issuer['description']['VALUE'] . '</option>';
-        }
-    } else {
         foreach ($iDealIssuers['issuers']['issuer'] as $issuer) {
-            $idealselect .= '<option value="' . $issuer['code']['VALUE'] . '">' . $issuer['description']['VALUE'] . '</option>';
+            if (!empty($issuer['code']['VALUE']) && !empty($issuer['description']['VALUE'])) {
+                $idealselect .= '<option value="' . $issuer['code']['VALUE'] . '">' . $issuer['description']['VALUE'] . '</option>';
+            }
         }
     }
-    $idealselect .= '</select>';
-
-
+    else {
+        // There are no banks available
+        $idealselect .= '<option value="">Er zijn geen banken beschikbaar</option>';
+    }
+    $idealselect .= '</select></div>';
 
     return $idealselect;
 }
 
-?>
+?>
diff --git a/src/app/lib/vendor/smarty/smarty/libs/plugins/block.msp_issuers.php b/src/app/lib/vendor/smarty/smarty/libs/plugins/block.msp_issuers.php
@@ -32,8 +32,6 @@ function smarty_block_msp_issuers($params, $content, &$smarty, &$repeat)
 
     require_once (DIR_ROOT . '/app/payments/MultiSafepay.combined.php');
 
-
-
     if ($processor_data['processor_params']['mode'] == 'T') {
         $test = true;
     } else {
@@ -48,23 +46,26 @@ function smarty_block_msp_issuers($params, $content, &$smarty, &$repeat)
 
     $iDealIssuers = $msp->getIdealIssuers();
 
+    $idealselect = '<div class="litecheckout__field cm-field-container litecheckout__field--small litecheckout__field--state">';
+    $idealselect .= '<select name="payment_info[issuer]" class="issuerselect litecheckout__input litecheckout__input--selectable litecheckout__input--selectable--select" id="issuerselect">';
 
-    $idealselect = '<select name="payment_info[issuer]" class="issuerselect" id="issuerselect"><option value="">Kies uw bank</option>';
+    if (!empty($iDealIssuers['issuers']['issuer'])) {
+        $idealselect .= '<option value="">Kies uw bank</option>';
 
-    if ($processor_data['processor_params']['mode'] == 'T') {
-        foreach ($iDealIssuers['issuers'] as $issuer) {
-            $idealselect .= '<option value="' . $issuer['code']['VALUE'] . '">' . $issuer['description']['VALUE'] . '</option>';
-        }
-    } else {
         foreach ($iDealIssuers['issuers']['issuer'] as $issuer) {
-            $idealselect .= '<option value="' . $issuer['code']['VALUE'] . '">' . $issuer['description']['VALUE'] . '</option>';
+            if (!empty($issuer['code']['VALUE']) && !empty($issuer['description']['VALUE'])) {
+                $idealselect .= '<option value="' . $issuer['code']['VALUE'] . '">' . $issuer['description']['VALUE'] . '</option>';
+            }
         }
     }
-    $idealselect .= '</select>';
-
-
+    else {
+        // There are no banks available
+        $idealselect .= '<option value="">Er zijn geen banken beschikbaar</option>';
+    }
+    $idealselect .= '</select></div>';
 
     return $idealselect;
 }
 
-?>
+?>
+