Add support for Vimeo videos #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # projects/ng-gallery-demo/src/app/pages/templates-example/templates-example.component.html # projects/ng-gallery/src/lib/components/gallery-item.component.ts # projects/ng-gallery/src/lib/components/gallery.component.ts # projects/ng-gallery/src/lib/components/templates/items.model.ts
|
I have resolved the merge issues since the v11 update, and I've tested this, and it's still working just fine. Some logic around fetching a Vimeo thumbnail got a lot simpler than before, I opened an issue over there and it was resolved. For reference: ThatGuySam/vumbnail#42 |
|
This PR has been sitting here for over a year now. I have just resolved the merge conflict regarding the new control-flow syntax. |
|
Hi @ChrisMBarr I am sorry - I think the last time I looked into this it had conflicts. Could you rebase the PR? it would be better to squash your commits into one. |
|
Can you just do a squash merge? I am able to do this on projects that I own |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now videos from Vimeo.com can be added to a gallery just like YouTube by simply provide the video ID from the URL. For example this video: https://vimeo.com/124139626 is embedded like so:
Here's a screen recording of that Vimeo video working on the demo page.
Searching through old issues, this addresses additional concerns already addressed by #22, and might possibly address #539
The only thing not covered by this PR is updating all the wiki pages that mention youtube to also have mentions and code examples of Vimeo as well.