Remove osc-min dependency #123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to #115 Remove the `osc-min` dependency and implement custom OSC encoding/decoding functions. * **Remove `osc-min` dependency** - Remove `osc-min` from `package.json`. - Remove `#decode` alias from `package.json`. * **Update `Client.mjs`** - Import `toBuffer` from `internal/osc.mjs`. - Update `send` method to use the new `toBuffer` function. * **Update `Server.mjs`** - Import `fromBuffer` from `internal/osc.mjs`. - Update `message` event handler to use the new `fromBuffer` function. * **Add `internal/osc.mjs`** - Implement `toBuffer` function to encode OSC messages. - Implement `fromBuffer` function to decode OSC messages. * **Update `rollup.config.mjs`** - Remove `osc-min` and `#decode` from the `external` array in the `walkLib` function. - Remove `osc-min` and `#decode` from the `external` array in the `walkTest` function. * **Add tests for new implementation** - Add `test/test-osc.mjs` with tests for `toBuffer` and `fromBuffer` functions. * **Remove old files** - Delete `lib/internal/decode.mjs`. - Delete `test/test-decode.mjs`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/MylesBorins/node-osc/issues/115?shareId=XXXX-XXXX-XXXX-XXXX).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #115
Remove the
osc-mindependency and implement custom OSC encoding/decoding functions.Remove
osc-mindependencyosc-minfrompackage.json.#decodealias frompackage.json.Update
Client.mjstoBufferfrominternal/osc.mjs.sendmethod to use the newtoBufferfunction.Update
Server.mjsfromBufferfrominternal/osc.mjs.messageevent handler to use the newfromBufferfunction.Add
internal/osc.mjstoBufferfunction to encode OSC messages.fromBufferfunction to decode OSC messages.Update
rollup.config.mjsosc-minand#decodefrom theexternalarray in thewalkLibfunction.osc-minand#decodefrom theexternalarray in thewalkTestfunction.Add tests for new implementation
test/test-osc.mjswith tests fortoBufferandfromBufferfunctions.Remove old files
lib/internal/decode.mjs.test/test-decode.mjs.For more details, open the Copilot Workspace session.