Skip to content

Commit

Permalink
add metrics for latency apart from utilisation
Browse files Browse the repository at this point in the history
  • Loading branch information
akichidis committed Feb 6, 2024
1 parent 0cb28ab commit 32976a1
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 0 deletions.
2 changes: 2 additions & 0 deletions mysticeti-core/src/crypto.rs
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,7 @@ impl PublicKey {
let _timer = metrics
.utilization_timer
.utilization_timer("PublicKey::verify_block");
let _latency_timer = metrics.verify_block_latency.start_timer();
let signature = Ed25519Signature::from_bytes(block.signature().as_bytes())
.expect("Failed to convert signature");
let mut hasher = BlockHasher::default();
Expand Down Expand Up @@ -244,6 +245,7 @@ impl Signer {
let _timer = metrics
.utilization_timer
.utilization_timer("Signer::sign_block");
let _latency_timer = metrics.sign_block_latency.start_timer();
let signature = self.0.sign(digest.as_ref());
SignatureBytes(
signature
Expand Down
14 changes: 14 additions & 0 deletions mysticeti-core/src/metrics.rs
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,8 @@ pub struct Metrics {
pub add_block_latency: HistogramVec,
pub quorum_receive_latency: Histogram,
pub ready_new_block: IntCounterVec,
pub sign_block_latency: Histogram,
pub verify_block_latency: Histogram,
}

pub struct MetricReporter {
Expand Down Expand Up @@ -406,6 +408,18 @@ impl Metrics {
registry,
).unwrap(),

sign_block_latency: register_histogram_with_registry!(
"sign_block_latency",
"The time it takes to sign a block",
registry
).unwrap(),

verify_block_latency: register_histogram_with_registry!(
"verify_block_latency",
"The time it takes to verify a block",
registry
).unwrap(),

transaction_certified_latency,
certificate_committed_latency,
transaction_committed_latency,
Expand Down

0 comments on commit 32976a1

Please sign in to comment.