Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use path buffer provided by caller in recv*_with_path #105

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

jpcsmith
Copy link
Contributor

This commit modifies the path types to be generic over the underlying storage. This enables us to store paths in buffers provided by a caller as opposed to needing to allocate storage for paths.

Copy link
Contributor

github-actions bot commented Dec 17, 2023

Code Coverage

Package Line Rate Health
crates/scion-proto/src/path 83%
crates/scion/src/daemon 95%
crates/scion-proto/src/path/metadata 100%
crates/scion-proto/src/reliable 95%
crates/scion-proto/src/packet/headers 86%
crates/scion-proto/src 80%
crates/scion-proto/src/packet 83%
crates/scion-proto/src/address 68%
crates/scion/src 84%
Summary 81% (1129 / 1402)

@jpcsmith jpcsmith marked this pull request as ready for review December 17, 2023 10:17
Copy link
Contributor

@mlegner mlegner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these nice efficiency improvements!

I have two significant comments and some nitpicks.

crates/scion-proto/src/path/standard.rs Show resolved Hide resolved
crates/scion-proto/src/path/standard.rs Show resolved Hide resolved
crates/scion-proto/src/path/dataplane.rs Outdated Show resolved Hide resolved
crates/scion/src/udp_socket.rs Outdated Show resolved Hide resolved
crates/scion/src/udp_socket.rs Outdated Show resolved Hide resolved
crates/scion/src/udp_socket.rs Outdated Show resolved Hide resolved
crates/scion/src/udp_socket.rs Show resolved Hide resolved
Copy link
Contributor

@mlegner mlegner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

This commit modifies the path types to be generic over the underlying storage.
This enables us to store paths in buffers provided by a caller as opposed to
needing to allocate storage for paths.
@jpcsmith jpcsmith merged commit f45a231 into main Dec 19, 2023
11 checks passed
@jpcsmith jpcsmith deleted the refactor/recv-path branch December 19, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants