Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: SCION SCMP packets and improved packet handling #113

Merged
merged 3 commits into from
Jan 10, 2024
Merged

feat: SCION SCMP packets and improved packet handling #113

merged 3 commits into from
Jan 10, 2024

Conversation

mlegner
Copy link
Contributor

@mlegner mlegner commented Dec 22, 2023 •
edited
Loading

Contributes to #54

@mlegner mlegner mentioned this pull request Dec 22, 2023
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 22, 2023 •
edited
Loading

Code Coverage

Package Line Rate Health
crates/scion-proto/src/scmp 77% ✔
crates/scion/src/pan 49% ❌
crates/scion-proto/src/path/metadata 100% ✔
crates/scion-proto/src/address 70% ➖
crates/scion/src/daemon 95% ✔
crates/scion-proto/src/path/standard 92% ✔
crates/scion-proto/src/packet 81% ✔
crates/scion-proto/src/path 83% ✔
crates/scion/src 79% ✔
crates/scion-proto/src 80% ✔
crates/scion-proto/src/reliable 95% ✔
crates/scion-proto/src/packet/headers 85% ✔
Summary 79% (1588 / 1999) ✔

@mlegner mlegner marked this pull request as ready for review December 22, 2023 13:09
@mlegner mlegner requested a review from jpcsmith as a code owner December 22, 2023 13:09
jpcsmith
jpcsmith approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@jpcsmith jpcsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Markus, looks good. Just a few nits.

crates/scion-proto/src/packet/headers.rs Show resolved Hide resolved
crates/scion-proto/src/path/standard.rs Outdated Show resolved Hide resolved
crates/scion-proto/src/path/standard.rs Outdated Show resolved Hide resolved
crates/scion-proto/src/packet/scmp.rs Outdated Show resolved Hide resolved
crates/scion-proto/src/packet/scmp.rs Outdated Show resolved Hide resolved
crates/scion-proto/src/scmp/messages.rs Outdated Show resolved Hide resolved
@mlegner
refactor: add trait for checksums
dae08ee 
Unify interface for SCMP and UDP.
@mlegner mlegner force-pushed the feat/scmp-packets branch from 3aa04f3 to c6b866f Compare January 8, 2024 15:56
@mlegner mlegner requested a review from jpcsmith January 8, 2024 15:57
jpcsmith
jpcsmith approved these changes Jan 9, 2024
View reviewed changes
crates/scion-proto/src/path/standard/meta_header.rs Outdated Show resolved Hide resolved
crates/scion-proto/src/path/standard/meta_header.rs Outdated Show resolved Hide resolved
crates/scion-proto/src/path/standard.rs Outdated Show resolved Hide resolved
crates/scion-proto/src/packet/scmp.rs Show resolved Hide resolved
crates/scion-proto/src/packet/headers.rs Outdated Show resolved Hide resolved
crates/scion-proto/src/packet/headers/common_header.rs Outdated Show resolved Hide resolved
crates/scion-proto/src/packet/headers.rs Outdated Show resolved Hide resolved
@mlegner mlegner mentioned this pull request Jan 9, 2024
Open
@mlegner mlegner force-pushed the feat/scmp-packets branch from c6b866f to b739d40 Compare January 9, 2024 17:54
@jpcsmith jpcsmith merged commit 4f14b57 into main Jan 10, 2024
11 checks passed
@jpcsmith jpcsmith deleted the feat/scmp-packets branch January 10, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpcsmith jpcsmith jpcsmith approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request refactor rust tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlegner @jpcsmith