-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add path refresher strategy #120
Conversation
@mlegner Could you have a look at this when you have a moment please? It's mostly done with the exception of needed to add an integration test. |
|
Thanks for the PR, @jpcsmith, I will take a look today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing this, @jpcsmith.
Everything looks good from my side. I will take a look at the tests together with the missing integration test.
c14cbc9
to
c125c5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, I think this test suite sets a new standard for future code. 🤩
All looks good, just a few nits and minor remarks.
c125c5e
to
f67b7ff
Compare
Add a path strategy that periodically refreshes paths.
Remaining tasks: