Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improve docstrings in the scion and scion-grpc crates #132

Merged
merged 1 commit into from
Jan 26, 2024
Merged

docs: improve docstrings in the scion and scion-grpc crates #132

merged 1 commit into from
Jan 26, 2024

Conversation

mlegner
Copy link
Contributor

@mlegner mlegner commented Jan 26, 2024

Contributes to #123.

@mlegner mlegner added the documentation Improvements or additions to documentation label Jan 26, 2024
@mlegner mlegner requested a review from jpcsmith as a code owner January 26, 2024 13:29
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 26, 2024 •
edited
Loading

Code Coverage

Package Line Rate Health
crates/scion/src/socket 77% ✔
crates/scion-proto/src/address 70% ➖
crates/scion-proto/src 79% ✔
crates/scion/src/pan/path_strategy 83% ✔
crates/scion-proto/src/packet 80% ✔
crates/scion-proto/src/reliable 95% ✔
crates/scion/src 80% ✔
crates/scion/src/daemon 91% ✔
crates/scion-proto/src/path 83% ✔
crates/scion/src/pan 78% ✔
crates/scion-proto/src/path/standard 92% ✔
crates/scion-proto/src/packet/headers 85% ✔
crates/scion-proto/src/scmp 77% ✔
crates/scion-proto/src/path/metadata 100% ✔
Summary 79% (1929 / 2427) ✔

jpcsmith
jpcsmith approved these changes Jan 26, 2024
View reviewed changes
.editorconfig Show resolved Hide resolved
crates/scion/src/pan/path_strategy.rs Outdated Show resolved Hide resolved
@mlegner mlegner force-pushed the docs/docstrings-scion branch from 208175d to 0d62f4a Compare January 26, 2024 14:01
@mlegner mlegner requested a review from jpcsmith January 26, 2024 14:02
@jpcsmith jpcsmith merged commit 6b1ebe3 into main Jan 26, 2024
11 checks passed
@jpcsmith jpcsmith deleted the docs/docstrings-scion branch January 26, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpcsmith jpcsmith Awaiting requested review from jpcsmith jpcsmith is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlegner @jpcsmith