Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move param_test to own crate and refactor some tests #135

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

jpcsmith
Copy link
Contributor

@jpcsmith jpcsmith commented Jan 29, 2024

Added the test-utils crate with the param_test macro and tested it out by refactoring some of our tests.]

Contributes to #124

@jpcsmith jpcsmith requested a review from mlegner as a code owner January 29, 2024 18:55
Copy link
Contributor

github-actions bot commented Jan 29, 2024

Code Coverage

Package Line Rate Health
crates/scion/src/pan/path_strategy 83%
crates/scion/src 80%
crates/scion-proto/src/packet 80%
crates/test-utils/src 100%
crates/scion/src/socket 77%
crates/scion-proto/src/path 83%
crates/scion/src/daemon 91%
crates/scion-proto/src/address 69%
crates/scion-proto/src/packet/headers 85%
crates/scion/src/pan 78%
crates/scion-proto/src/reliable 95%
crates/scion-proto/src/scmp 77%
crates/scion-proto/src/path/standard 92%
crates/scion-proto/src/path/metadata 100%
crates/scion-proto/src 79%
Summary 79% (1935 / 2436)

crates/test-utils/src/lib.rs Show resolved Hide resolved
crates/test-utils/src/lib.rs Show resolved Hide resolved
@jpcsmith jpcsmith force-pushed the refactor/test-utils branch from 9d8e5e7 to 898680e Compare January 30, 2024 17:59
@jpcsmith jpcsmith merged commit b4d3085 into main Jan 30, 2024
11 checks passed
@jpcsmith jpcsmith deleted the refactor/test-utils branch January 30, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants