Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new crate scion-grpc with setup for sciond #20

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Conversation

mlegner
Copy link
Contributor

@mlegner mlegner commented Oct 3, 2023

This adds protobuf definitions and gRPC generation for the sciond communication. This is largely copied from https://github.com/MystenLabs/scion-hp-market/tree/main/crates/scion-grpc (partially from https://github.com/scionproto/scion, partially authored by @jpcsmith), but I left out all the other protobuf definitions as we probably won't need them.

The PR also updates other project setup as required by the protobuf addition.

Contributes to #12

@mlegner mlegner added documentation Improvements or additions to documentation enhancement New feature or request github_actions Pull requests that update GitHub Actions code rust labels Oct 3, 2023
@mlegner mlegner requested a review from jpcsmith as a code owner October 3, 2023 12:53
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

Code Coverage

Package Line Rate Health
crates/scion/src 88%
crates/scion/src/address 88%
crates/scion/src/daemon 0%
crates/scion-grpc 0%
crates/scion-grpc/src 0%
Summary 88% (112 / 128)

Copy link
Contributor

@jpcsmith jpcsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Question: Is the plan to use the tonic GRPC types and service directly in the socket?

@jpcsmith jpcsmith merged commit 14abd31 into main Oct 3, 2023
11 checks passed
@jpcsmith jpcsmith deleted the feat/sciond-grpc branch October 3, 2023 14:45
@mlegner
Copy link
Contributor Author

mlegner commented Oct 3, 2023

Question: Is the plan to use the tonic GRPC types and service directly in the socket?

I was actually thinking about this. My plan so far was to use them directly unless a there is a concrete need or use case for some additional abstraction/wrappers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request github_actions Pull requests that update GitHub Actions code rust
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants