Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add SCION packet structure and parsing #31

Merged
merged 1 commit into from
Nov 1, 2023
Merged

feat: add SCION packet structure and parsing #31

merged 1 commit into from
Nov 1, 2023

Conversation

jpcsmith
Copy link
Contributor

No description provided.

@jpcsmith jpcsmith self-assigned this Oct 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023 •
edited
Loading

Code Coverage

Package Line Rate Health
crates/scion-grpc/src 0% ❌
crates/scion/src/address 95% ✔
crates/scion/src 86% ✔
crates/scion/src/path 89% ✔
crates/scion/src/daemon 0% ❌
crates/scion/src/packet 65% ➖
crates/scion-grpc 0% ❌
crates/scion/src/reliable 95% ✔
Summary 86% (554 / 646) ✔

@jpcsmith jpcsmith marked this pull request as ready for review October 27, 2023 15:37
mlegner
mlegner reviewed Oct 30, 2023
View reviewed changes
Copy link
Contributor

@mlegner mlegner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpcsmith Amazing work as usual. Only minor comments and suggestions from my side.

crates/scion/src/packet.rs Outdated Show resolved Hide resolved
crates/scion/src/packet.rs Outdated Show resolved Hide resolved
crates/scion/src/packet/wire_encoding.rs Outdated Show resolved Hide resolved
crates/scion/src/packet/common_header.rs Outdated Show resolved Hide resolved
crates/scion/src/packet/common_header.rs Show resolved Hide resolved
crates/scion/src/packet/address_header.rs Outdated Show resolved Hide resolved
crates/scion/src/packet/path_header.rs Outdated Show resolved Hide resolved
crates/scion/src/packet/path_header.rs Outdated Show resolved Hide resolved
crates/scion/src/packet/path_header.rs Outdated Show resolved Hide resolved
crates/scion/src/packet/path_header.rs Show resolved Hide resolved
jpcsmith
jpcsmith commented Nov 1, 2023
View reviewed changes
Copy link
Contributor Author

@jpcsmith jpcsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the suggested changes, mind having another look @mlegner.

crates/scion/src/packet/address_header.rs Outdated Show resolved Hide resolved
crates/scion/src/packet/common_header.rs Outdated Show resolved Hide resolved
crates/scion/src/packet/path_header.rs Outdated Show resolved Hide resolved
crates/scion/src/packet/path_header.rs Outdated Show resolved Hide resolved
@jpcsmith jpcsmith requested a review from mlegner November 1, 2023 08:07
mlegner
mlegner approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@mlegner mlegner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the changes, @jpcsmith! The only thing left is the (optional) renaming of the truncated-packet error.

@jpcsmith jpcsmith merged commit 8633112 into main Nov 1, 2023
11 checks passed
@jpcsmith jpcsmith deleted the feat/layers branch November 1, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlegner mlegner mlegner approved these changes

Assignees

@jpcsmith jpcsmith

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpcsmith @mlegner