Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add socket address and simplify parse errors #33

Merged
merged 2 commits into from
Nov 2, 2023
Merged

feat: add socket address and simplify parse errors #33

merged 2 commits into from
Nov 2, 2023

Conversation

jpcsmith
Copy link
Contributor

@jpcsmith jpcsmith commented Nov 1, 2023 •
edited
Loading

This PR adds the SocketAddr type for the transport layer, and makes address parsing errors opaque, akin to those in the std::net::AddrParseError.

@jpcsmith jpcsmith self-assigned this Nov 1, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2023 •
edited
Loading

Code Coverage

Package Line Rate Health
crates/scion/src/address 71% ➖
crates/scion/src 79% ✔
crates/scion/src/path 89% ✔
crates/scion/src/daemon 0% ❌
crates/scion-grpc/src 0% ❌
crates/scion/src/reliable 95% ✔
crates/scion-grpc 0% ❌
crates/scion/src/packet 65% ➖
Summary 79% (574 / 723) ✔

@jpcsmith jpcsmith marked this pull request as ready for review November 1, 2023 10:21
mlegner
mlegner approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@mlegner mlegner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jpcsmith, LGTM. Just one suggestion to deduplicate some of the code (and remove ~100 LOC) by including it in the macro.

crates/scion/src/address/socket_address.rs Show resolved Hide resolved
crates/scion/src/address/socket_address.rs Outdated Show resolved Hide resolved
@jpcsmith @mlegner
refactor: simplify socket implementation with macro
9d99de7 
Co-authored-by: Markus Legner <mlegner@users.noreply.github.com>
@jpcsmith jpcsmith merged commit 46baf94 into main Nov 2, 2023
11 checks passed
@jpcsmith jpcsmith deleted the feat/socket-addr branch November 2, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlegner mlegner mlegner approved these changes

Assignees

@jpcsmith jpcsmith

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpcsmith @mlegner