Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: receive UDP datagrams #68

Merged
merged 1 commit into from
Dec 4, 2023
Merged

feat: receive UDP datagrams #68

merged 1 commit into from
Dec 4, 2023

Conversation

jpcsmith
Copy link
Contributor

@jpcsmith jpcsmith commented Nov 30, 2023 •
edited by mlegner
Loading

Comments are based on commit f053283

Depends on #67.

Closes #61

@jpcsmith jpcsmith self-assigned this Nov 30, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 30, 2023 •
edited
Loading

Code Coverage

Package Line Rate Health
crates/scion/src/daemon 94% ✔
crates/scion/src 56% ➖
crates/scion-proto/src/path/metadata 100% ✔
crates/scion-proto/src/packet 77% ✔
crates/scion-proto/src/address 71% ➖
crates/scion-proto/src/path 82% ✔
crates/scion/src/udp 0% ❌
crates/scion-proto/src 78% ✔
crates/scion-proto/src/reliable 97% ✔
Summary 74% (710 / 956) ➖

@jpcsmith
Copy link
Contributor Author

@mlegner This is an early draft, but would be great to get your feedback on some points.

@mlegner mlegner mentioned this pull request Dec 1, 2023
Merged
@jpcsmith jpcsmith marked this pull request as ready for review December 4, 2023 13:23
@jpcsmith jpcsmith requested a review from mlegner December 4, 2023 13:23
mlegner
mlegner reviewed Dec 4, 2023
View reviewed changes
Copy link
Contributor

@mlegner mlegner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jpcsmith, looks good to me. I'm just a little worried about the performance impact of the deep copy of the path header. Could you elaborate on the reasoning of that?

crates/scion/src/udp/socket.rs Show resolved Hide resolved
crates/scion-proto/src/packet/path_header.rs Show resolved Hide resolved
@mlegner mlegner mentioned this pull request Dec 4, 2023
Closed
@mlegner mlegner merged commit ef6dc88 into main Dec 4, 2023
11 checks passed
@mlegner mlegner deleted the feat/udp-receive branch December 4, 2023 14:59
@mlegner mlegner mentioned this pull request Dec 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlegner mlegner mlegner approved these changes

Assignees

@jpcsmith jpcsmith

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement UDP datagram receiving.
2 participants
@jpcsmith @mlegner