Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: unify dependencies among crates #69

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Conversation

jpcsmith
Copy link
Contributor

@jpcsmith jpcsmith commented Dec 1, 2023

An update to a few crates caused duplicate dependencies which were disallowed by cargo-deny.

This PR allows the windows-sys duplicate and also refactors our crates to share versions of packages.

Copy link
Contributor

github-actions bot commented Dec 1, 2023

Code Coverage

Package Line Rate Health
crates/scion-proto/src/packet 75%
crates/scion-proto/src/path 84%
crates/scion/src/udp 0%
crates/scion-proto/src/path/metadata 100%
crates/scion-proto/src/address 72%
crates/scion/src/daemon 94%
crates/scion/src 70%
crates/scion-proto/src 79%
crates/scion-proto/src/reliable 97%
Summary 78% (667 / 857)

@jpcsmith jpcsmith marked this pull request as ready for review December 1, 2023 10:38
@jpcsmith
Copy link
Contributor Author

jpcsmith commented Dec 1, 2023

@mlegner Could you please have a look when you have a moment.

Copy link
Contributor

@mlegner mlegner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the housekeeping, @jpcsmith! 🙏

@mlegner mlegner merged commit f0d63d0 into main Dec 1, 2023
11 checks passed
@mlegner mlegner deleted the refactor/dependency-mgmt branch December 1, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants