Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use an enum for dataplane paths #70

Merged
merged 1 commit into from
Dec 1, 2023
Merged

feat: use an enum for dataplane paths #70

merged 1 commit into from
Dec 1, 2023

Conversation

jpcsmith
Copy link
Contributor

@jpcsmith jpcsmith commented Dec 1, 2023

No description provided.

@jpcsmith jpcsmith self-assigned this Dec 1, 2023
Copy link
Contributor

github-actions bot commented Dec 1, 2023

Code Coverage

Package Line Rate Health
crates/scion-proto/src/path/metadata 100%
crates/scion-proto/src/address 72%
crates/scion-proto/src 78%
crates/scion/src 70%
crates/scion-proto/src/reliable 97%
crates/scion-proto/src/path 84%
crates/scion-proto/src/packet 74%
crates/scion/src/daemon 94%
crates/scion/src/udp 0%
Summary 77% (659 / 853)

Copy link
Contributor

@mlegner mlegner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, LGTM. 💯

crates/scion-proto/src/packet/path_header.rs Outdated Show resolved Hide resolved
@jpcsmith jpcsmith enabled auto-merge (rebase) December 1, 2023 15:37
@jpcsmith jpcsmith merged commit e4385e7 into main Dec 1, 2023
11 checks passed
@jpcsmith jpcsmith deleted the feat/path-enum branch December 1, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants