Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: various improvements and integration tests for UDP socket #87

Merged
merged 7 commits into from
Dec 8, 2023
Merged

feat: various improvements and integration tests for UDP socket #87

merged 7 commits into from
Dec 8, 2023

Conversation

mlegner
Copy link
Contributor

@mlegner mlegner commented Dec 7, 2023 •
edited
Loading

  • add simple env config for daemon and dispatcher
  • allow empty paths in daemon response
  • construct CommonHeader in ScionHeaders::new
  • improve setup instructions
  • add some unit tests
  • add integration tests for UDP socket

Closes #77

Closes #83

Closes #86

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023 •
edited
Loading

Code Coverage

Package Line Rate Health
crates/scion/src 84% ✔
crates/scion-proto/src/path/metadata 100% ✔
crates/scion-proto/src 84% ✔
crates/scion/src/daemon 95% ✔
crates/scion-proto/src/address 80% ✔
crates/scion-proto/src/packet 83% ✔
crates/scion-proto/src/reliable 97% ✔
crates/scion-proto/src/path 84% ✔
crates/scion-proto/src/packet/headers 88% ✔
Summary 84% (972 / 1161) ✔

@mlegner mlegner changed the title test: add integration tests for UDP socket and various improvements feat: various improvements and integration tests for UDP socket Dec 7, 2023
jpcsmith
jpcsmith reviewed Dec 7, 2023
View reviewed changes
Copy link
Contributor

@jpcsmith jpcsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just 1 issue.

crates/scion-proto/src/packet/headers/common_header.rs Outdated Show resolved Hide resolved
crates/scion-proto/src/packet/headers/path_header.rs Outdated Show resolved Hide resolved
crates/scion-proto/src/path.rs Outdated Show resolved Hide resolved
@mlegner mlegner requested a review from jpcsmith December 7, 2023 15:40
@mlegner mlegner merged commit 3d81687 into main Dec 8, 2023
11 checks passed
@mlegner mlegner deleted the test/udp-socket branch December 8, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpcsmith jpcsmith jpcsmith approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request refactor rust tests
Projects
None yet
Milestone
No milestone
2 participants
@mlegner @jpcsmith