feat: add ScionAddr type of ISD-AS and host #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@mlegner This adds the ScionAddr type. There is a lot of renaming going on as well, so you may want to look at the individual commits since the renaming is isolated to the first and last commits. |
mlegner
reviewed
Dec 7, 2023
jpcsmith
force-pushed
the
feat/scion-addr
branch
from
6e49267
to
e9aeb9e
Compare
This flattens HostAddr to make mapping to the underlying type more straightforward, renames it to HostAddr (like IpAddr), and removes the HostAddress marker trait to avoid confusion.
jpcsmith
force-pushed
the
feat/scion-addr
branch
from
e9aeb9e
to
40220e6
Compare
mlegner
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #78.