Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: generally disallow missing Rust docs and check in CI and pre-commit #90

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

mlegner
Copy link
Contributor

@mlegner mlegner commented Dec 8, 2023

I've added some short missing documentation in many places, fixed broken internal links, and added #[allow(missing_doc)] in several other places.

The idea is to add docstrings for any new code and add missing documentation whenever touching a module that has some.

Closes #82

Also fix lint errors.

Currently still allow missing documentation.
Add missing docs in some places and  in others.
@mlegner mlegner added documentation Improvements or additions to documentation github_actions Pull requests that update GitHub Actions code rust labels Dec 8, 2023
Copy link
Contributor

github-actions bot commented Dec 8, 2023

Code Coverage

Package Line Rate Health
crates/scion-proto/src/path/metadata 100%
crates/scion-proto/src/reliable 95%
crates/scion/src 84%
crates/scion-proto/src/packet/headers 87%
crates/scion-proto/src/address 67%
crates/scion-proto/src 79%
crates/scion/src/daemon 95%
crates/scion-proto/src/packet 82%
crates/scion-proto/src/path 84%
Summary 80% (988 / 1238)

@jpcsmith jpcsmith merged commit 5cea3bd into main Dec 11, 2023
11 checks passed
@jpcsmith jpcsmith deleted the chore/rust-doc branch December 11, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation github_actions Pull requests that update GitHub Actions code rust
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create consistent standard of documentation for the crates
2 participants