Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement standard path reversal #91

Merged
merged 3 commits into from
Dec 12, 2023
Merged

feat: implement standard path reversal #91

merged 3 commits into from
Dec 12, 2023

Conversation

mlegner
Copy link
Contributor

@mlegner mlegner commented Dec 11, 2023 •
edited
Loading

  • Implement path reversal
  • Add unit tests
  • Add integration test

Closes #84

@mlegner mlegner added enhancement New feature or request rust labels Dec 11, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 11, 2023 •
edited
Loading

Code Coverage

Package Line Rate Health
crates/scion-proto/src/packet 79% ✔
crates/scion-proto/src 80% ✔
crates/scion-proto/src/packet/headers 84% ✔
crates/scion-proto/src/path 89% ✔
crates/scion-proto/src/path/metadata 100% ✔
crates/scion/src/daemon 95% ✔
crates/scion/src 83% ✔
crates/scion-proto/src/reliable 95% ✔
crates/scion-proto/src/address 68% ➖
Summary 80% (1036 / 1288) ✔

@mlegner mlegner force-pushed the feat/path-reversal branch 3 times, most recently from 52ec651 to 83933b1 Compare December 11, 2023 15:31
@mlegner mlegner marked this pull request as ready for review December 11, 2023 15:31
@mlegner mlegner mentioned this pull request Dec 11, 2023
Merged
jpcsmith
jpcsmith reviewed Dec 11, 2023
View reviewed changes
Copy link
Contributor

@jpcsmith jpcsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Markus, thank's for this. Couple of question on the design are attached.

crates/scion-proto/src/path.rs Outdated Show resolved Hide resolved
crates/scion-proto/src/path/standard.rs Show resolved Hide resolved
jpcsmith
jpcsmith approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@jpcsmith jpcsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, looks good.

crates/scion-proto/src/path/dataplane.rs Outdated Show resolved Hide resolved
@mlegner
chore: fix cargo-doc pre-commit config
65d7593
@mlegner
feat: implement standard path reversal
f9fc213 
- directly reverse path when receiving packets for supported path types
- integration tests for direct replies using reversed path
@mlegner mlegner enabled auto-merge (rebase) December 12, 2023 12:09
@mlegner mlegner merged commit 93b2d67 into main Dec 12, 2023
11 checks passed
@mlegner mlegner deleted the feat/path-reversal branch December 12, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpcsmith jpcsmith jpcsmith approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request rust
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement path reversal.
2 participants
@mlegner @jpcsmith