Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: allow setters to be used on shared socket #94

Merged
merged 1 commit into from
Dec 13, 2023
Merged

refactor: allow setters to be used on shared socket #94

merged 1 commit into from
Dec 13, 2023

Conversation

jpcsmith
Copy link
Contributor

@jpcsmith jpcsmith commented Dec 12, 2023 •
edited by mlegner
Loading

Depends on #92, closes #80, contributes to #89.

@jpcsmith jpcsmith self-assigned this Dec 12, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2023 •
edited
Loading

Code Coverage

Package Line Rate Health
crates/scion-proto/src 80% ✔
crates/scion/src/daemon 95% ✔
crates/scion-proto/src/packet 79% ✔
crates/scion-proto/src/path/metadata 100% ✔
crates/scion-proto/src/reliable 95% ✔
crates/scion-proto/src/packet/headers 84% ✔
crates/scion-proto/src/path 88% ✔
crates/scion/src 84% ✔
crates/scion-proto/src/address 68% ➖
Summary 80% (1064 / 1322) ✔

@jpcsmith jpcsmith marked this pull request as ready for review December 12, 2023 14:57
@mlegner mlegner mentioned this pull request Dec 12, 2023
Closed
mlegner
mlegner approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@mlegner mlegner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @jpcsmith, very nice setup.

Just one nit and one minor suggestion from my side.

crates/scion/src/udp_socket.rs Outdated Show resolved Hide resolved
crates/scion/tests/test_udp_socket.rs Outdated Show resolved Hide resolved
@jpcsmith jpcsmith mentioned this pull request Dec 13, 2023
Closed
@jpcsmith jpcsmith force-pushed the refactor/socket-setters branch 2 times, most recently from 902933b to 0c96dc6 Compare December 13, 2023 08:59
@jpcsmith jpcsmith merged commit 4295724 into main Dec 13, 2023
11 checks passed
@jpcsmith jpcsmith deleted the refactor/socket-setters branch December 13, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlegner mlegner mlegner approved these changes

Assignees

@jpcsmith jpcsmith

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure setting remote address and path on the UdpSocket works in an async context
2 participants
@jpcsmith @mlegner