Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct and test send and receive corner cases #99

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

jpcsmith
Copy link
Contributor

@jpcsmith jpcsmith commented Dec 13, 2023

Closes #89

@jpcsmith jpcsmith self-assigned this Dec 13, 2023
Copy link
Contributor

github-actions bot commented Dec 13, 2023

Code Coverage

Package Line Rate Health
crates/scion/src/daemon 95%
crates/scion-proto/src/packet/headers 86%
crates/scion-proto/src/path 88%
crates/scion-proto/src/path/metadata 100%
crates/scion-proto/src/packet 83%
crates/scion/src 86%
crates/scion-proto/src/address 68%
crates/scion-proto/src 81%
crates/scion-proto/src/reliable 95%
Summary 82% (1098 / 1343)

Copy link
Contributor

@mlegner mlegner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these nice improvements and tests, @jpcsmith. Just some minor comments from my side.

crates/scion/src/udp_socket.rs Show resolved Hide resolved
crates/scion/src/udp_socket.rs Outdated Show resolved Hide resolved
crates/scion/src/udp_socket.rs Show resolved Hide resolved
crates/scion/src/udp_socket.rs Show resolved Hide resolved
@jpcsmith jpcsmith merged commit 7980af0 into main Dec 14, 2023
11 checks passed
@jpcsmith jpcsmith deleted the fix/send-recv-corner-cases branch December 14, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit behavior of UDP socket and its connection states
2 participants