-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/loading indicators part 1 #1589
Draft
AaronPlave
wants to merge
15
commits into
develop
Choose a base branch
from
feat/loading-indicators-part-1
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronPlave
temporarily deployed
to
test-workflow
January 3, 2025 22:44 — with
GitHub Actions
Inactive
AaronPlave
temporarily deployed
to
test-workflow
January 3, 2025 22:48 — with
GitHub Actions
Inactive
AaronPlave
had a problem deploying
to
test-workflow
January 15, 2025 17:50 — with
GitHub Actions
Failure
AaronPlave
had a problem deploying
to
test-workflow
January 16, 2025 00:52 — with
GitHub Actions
Failure
AaronPlave
had a problem deploying
to
test-workflow
January 16, 2025 16:57 — with
GitHub Actions
Failure
AaronPlave
force-pushed
the
feat/loading-indicators-part-1
branch
from
January 17, 2025 16:19
e7eefdb
to
5d6fd20
Compare
AaronPlave
temporarily deployed
to
test-workflow
January 17, 2025 16:20 — with
GitHub Actions
Inactive
AaronPlave
force-pushed
the
feat/loading-indicators-part-1
branch
from
January 17, 2025 17:45
5d6fd20
to
68f1389
Compare
AaronPlave
temporarily deployed
to
test-workflow
January 17, 2025 17:45 — with
GitHub Actions
Inactive
AaronPlave
temporarily deployed
to
test-workflow
January 17, 2025 17:49 — with
GitHub Actions
Inactive
…e. Implement scheduling loading indication in relevant areas.
AaronPlave
force-pushed
the
feat/loading-indicators-part-1
branch
from
January 17, 2025 17:54
68f1389
to
733bf1e
Compare
AaronPlave
temporarily deployed
to
test-workflow
January 17, 2025 17:54 — with
GitHub Actions
Inactive
AaronPlave
temporarily deployed
to
test-workflow
January 17, 2025 18:01 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve initial data loading indication. Partially addresses #1581 and #832. General approach is to set various array stores
to null in order to detect if the subscription has returned any results at all yet.
Changes:
loading
prop to control the ag-grid loading messageTODO: